Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

Values Schema for Knative Serving #1940 #2054

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Values Schema for Knative Serving #1940 #2054

merged 2 commits into from
Sep 30, 2021

Conversation

seemiller
Copy link
Contributor

What this PR does / why we need it

Adds values-schema for the Knative Serving package.

Details for the Release Notes (PLEASE PROVIDE)

Adds values-schema for the Knative Serving package.

Which issue(s) this PR fixes

Fixes: #1940

Describe testing done for PR

apply the metadata and packages yaml files.

kubectl apply -f addons/packages/knative-serving/metadata.yaml 
kubectl apply -f addons/packages/knative-serving/0.22.0/package.yaml

Retrieve the values schema

tanzu package available get knative-serving.community.tanzu.vmware.com/0.22.0 --values-schema

Special notes for your reviewer

Signed-off-by: Nicholas Seemiller <nseemiller@vmware.com>
@seemiller seemiller requested a review from a team as a code owner September 30, 2021 15:27
@github-actions github-actions bot added the owner/packages Work executed by a package's maintainer label Sep 30, 2021
Copy link
Contributor

@jorgemoralespou jorgemoralespou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor typo. Apart from that LGTM.

Co-authored-by: Jorge Morales Pou <jorgemoralespou@users.noreply.github.com>
Copy link
Contributor

@jorgemoralespou jorgemoralespou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seemiller seemiller merged commit b019912 into main Sep 30, 2021
@seemiller seemiller deleted the knative-schema-1940 branch September 30, 2021 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required owner/packages Work executed by a package's maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add schema/properties to knative-serving package
3 participants