This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Implements adding values files for a image bundle #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bumps ytt to v0.37.0 - Implements AddYttYamlValuesBytes method to TkrImageReader - Implements AddYttKVsFromYAML method to TkrImageReader - Uses a null logger for imgpkg so logging is surpressed Signed-off-by: John McBride <jmcbride@vmware.com>
joshrosso
pushed a commit
that referenced
this pull request
Jan 18, 2022
- Bumps ytt to v0.37.0 - Implements AddYttYamlValuesBytes method to TkrImageReader - Implements AddYttKVsFromYAML method to TkrImageReader - Uses a null logger for imgpkg so logging is surpressed Signed-off-by: John McBride <jmcbride@vmware.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
All changes related to the standalone cluster overhaul
AddYttYamlValuesBytesmethod toTkrImageReaderAddYttKVsFromYAMLmethod toTkrImageReaderimgpkgso logging is suppressedA user can now specify
which will be used when rendering the ytt for that bundle
Which issue(s) this PR fixes
related to proposal #2266
Describe testing done for PR
Build with
make build-cli-plugins-localand ran the binary.With the changes made in
create.go, we now can fully use the TkrImageReader interface to download the bundle, add values, and render the ytt. many of those changes are temporary and were made for testing purposesSpecial notes for your reviewer
N/a