This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
improve package-release.sh by using ENVS variable #2385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pass ENVS to package-release.sh - remove duplicate instructions for each architecture, and instead loop through each element in ENVS Signed-off-by: Joe Fitzgerald <jfitzgerald@vmware.com>
github-actions
bot
added
the
owner/release-eng
Signed-off-by: Joe Fitzgerald <jfitzgerald@vmware.com>
davidvonthenen
suggested changes
Oct 28, 2021
Signed-off-by: Joe Fitzgerald <jfitzgerald@vmware.com>
Signed-off-by: Joe Fitzgerald <jfitzgerald@vmware.com>
davidvonthenen
approved these changes
Oct 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joe Fitzgerald jfitzgerald@vmware.com
What this PR does / why we need it
This PR improves the build script to remove duplication in
package-release.shby leveraging the ENVS variable set in theMakefile.package-release.shDetails for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
N/A
Describe testing done for PR
$ make releaseSpecial notes for your reviewer
N/A