This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Pre-Merge PR Checks for Diagnostics Plugin #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidvonthenen
requested review from
vladimirvivien,
karuppiah7890 and
a team
github-actions
bot
added
area/cli
owner/release-eng
davidvonthenen
dismissed stale reviews from karuppiah7890 and vladimirvivien
via
8c3c2c8
|
This is ready for review... the PR check is passing here: |
nrb
approved these changes
Nov 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This does the same thing as the e2e test on main... except this checks to make sure that PRs submitted against the diagnostics plugin will pass the tests before getting merged into main. If the test fails, merging will be blocked until the issue is addressed.
The
e2e-test.shwas broken out into:setup-e2e-test.shwhich handles setting things for the e2e teste2e-test.shwhich now only performs the checks/tests without setup so we can run against latest TFDetails for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
NA
Describe testing done for PR
NA
Special notes for your reviewer
NA