Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

Force data value hash to string in csi daemonset #2407

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Force data value hash to string in csi daemonset #2407

merged 1 commit into from
Oct 29, 2021

Conversation

vijaykatam
Copy link
Contributor

What this PR does / why we need it

Fix vsphere-csi 2.3.0 daemonset rollout when first 7 characters of data values hash is numeric

Details for the Release Notes (PLEASE PROVIDE)

Fix vsphere-csi 2.3.0 daemonset rollout when first 7 characters of data values hash is numeric

Which issue(s) this PR fixes

Fixes: #2406

Describe testing done for PR

  1. ytt render with data values
  2. verify with sample values that yields numeric characters for first 7 tokens

Special notes for your reviewer

@github-actions github-actions bot added the owner/packages Work executed by a package's maintainer label Oct 29, 2021
@vijaykatam vijaykatam requested a review from blc1996 October 29, 2021 19:10
blc1996
blc1996 approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@blc1996 blc1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vijaykatam vijaykatam merged commit 976f475 into main Oct 29, 2021
@stmcginnis stmcginnis deleted the vkatam/2406 branch November 9, 2021 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blc1996 blc1996 blc1996 approved these changes

Assignees
No one assigned
Labels
cla-not-required owner/packages Work executed by a package's maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vsphere-csi 2.3.0 package adds annotation as an integer
3 participants
@vijaykatam @blc1996 @vmwclabot