This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Standalone overhaul: Renames local to standalone within codebase
#2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John McBride <jmcbride@vmware.com>
github-actions
bot
added
area/cli
owner/docs
jpmcb
commented
Nov 1, 2021
| @@ -32,7 +32,7 @@ const ( | |||
| configFileName = "config.yaml" | |||
| tanzuConfigDir = "tanzu" | |||
| tkgConfigDir = "tkg" | |||
| localConfigDir = "local" | |||
| standaloneConfigDir = "standalone" | |||
There was a problem hiding this comment.
Note: This PR also introduces a breaking change where the configuration directory changes from
~/.config/tanzu/tkg/local/...
to
~/.config/tanzu/tkg/standalone/...
creating clusters and everything still works the same, but users won't be able to delete / list clusters they have currently in the local directory
stmcginnis
approved these changes
Nov 1, 2021
There was a problem hiding this comment.
This all looks good to me, but I'll leave it to @joshrosso to do the merge.
|
worked great in my test! |
joshrosso
pushed a commit
that referenced
this pull request
Jan 18, 2022
Signed-off-by: John McBride <jmcbride@vmware.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR renames instances of
local(and any variables derived from that) tostandaloneThis will be beneficial to any external programmer "users" who will be implementing their own providers to plug into the standalone model