This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Standalone overhaul: Implements a set of standard 2 column width emojis for logging #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmcb
force-pushed
the
standalone-hide-completions
branch
2 times, most recently
from
92f91d4 to
28c8d33
Compare
Signed-off-by: John McBride <jmcbride@vmware.com>
jpmcb
force-pushed
the
standalone-hide-completions
branch
from
28c8d33 to
c1e057c
Compare
|
Tried it locally, looks super good. |
joshrosso
pushed a commit
that referenced
this pull request
Jan 18, 2022
Signed-off-by: John McBride <jmcbride@vmware.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes related to the standalone cluster overhaul
What this PR does / why we need it
EventandEventflogger methods.kubectl get podsmight do)Describe testing done for PR
Take a look!