This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Fix ec2 instance leak when tagging fails #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
owner/release-eng
jpmcb
approved these changes
Nov 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This fixes a small ec2 instance leak when using self-hosted runners. This doesn't happen often (like once every day), but it does happen which leads to manual clean up for orphaned ec2 instances. If the tagging fails, delete the instance. Then (like normal) let the outer loop start the create-tag loop all over again.
Details for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
NA
Describe testing done for PR
NA
Special notes for your reviewer
NA