Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

addons/packages/pinniped: dedup HTTP proxy env vars #2618

Conversation

ankeesler
Copy link
Contributor

@ankeesler ankeesler commented Nov 29, 2021

These are injected via the upstream _ytt_lib logic.

What this PR does / why we need it

  • Deduplicate HTTP proxy env vars in Pinniped package

Before:

        env:
        - name: HTTPS_PROXY
          value: https://example.com
        - name: NO_PROXY
          value: 100.96.0.0/11,100.64.0.0/13,127.0.0.1,localhost,.svc,.svc.cluster.local,
        - name: HTTP_PROXY
          value: http://example.com
        - name: HTTPS_PROXY
          value: https://example.com
        - name: NO_PROXY
          value: 100.96.0.0/11,100.64.0.0/13,127.0.0.1,localhost,.svc,.svc.cluster.local,

After:

        env:
        - name: HTTPS_PROXY
          value: https://example.com
        - name: NO_PROXY
          value: 100.96.0.0/11,100.64.0.0/13,127.0.0.1,localhost,.svc,.svc.cluster.local,

Details for the Release Notes (PLEASE PROVIDE)

Pinniped package 0.12.0 no longer has duplicated HTTP proxy env vars

Which issue(s) this PR fixes

None

Describe testing done for PR

  • Deployed this dev package into an existing cluster and saw that HTTP proxy env vars were no longer duplicated

Special notes for your reviewer

None

@ankeesler ankeesler requested a review from a team as a code owner November 29, 2021 19:57
@github-actions github-actions bot added the owner/packages Work executed by a package's maintainer label Nov 29, 2021
@ankeesler ankeesler force-pushed the ankeesler/dedup-pinniped-http-proxy-env-vars branch from 3c5e30a to f8838d3 Compare November 29, 2021 19:57
These are injected via the upstream _ytt_lib logic.

Signed-off-by: Andrew Keesler <akeesler@vmware.com>
@ankeesler ankeesler force-pushed the ankeesler/dedup-pinniped-http-proxy-env-vars branch from f8838d3 to d281195 Compare November 29, 2021 19:58
Copy link
Member

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nifty.

@benjaminapetersen benjaminapetersen merged commit acf1e25 into vmware-tanzu:main Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required owner/packages Work executed by a package's maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants