This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Add missing fields to CPI schema #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
owner/packages
HanFa
reviewed
Jan 28, 2022
|
No, is this some new requirement? |
lubronzhan
force-pushed
the
fix_cpi_schema
branch
from
9a23c3c to
da3b633
Compare
|
Ok I ran the command again |
lubronzhan
changed the title
|
/lgtm |
HanFa
approved these changes
Jan 28, 2022
|
LGTM - sorry we missed this on the first review |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The CPI
schema.yamlis missing two important fields.Correct the sample-values folder's location
Details for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
Fixes: #
Describe testing done for PR
Special notes for your reviewer