This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Add Multus CNI package #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenliu1993
changed the title
chenliu1993
changed the title
jessehu
reviewed
May 19, 2021
addons/packages/multus-cni/bundle/config/overlays/overlay-multus-cni.yaml
Outdated
Show resolved
Hide resolved
jessehu
reviewed
May 19, 2021
|
LGTM. Thanks Chen 👍 |
The vendir yaml needed slight adjustment - running `vendir sync` was causing the values/overlays files to be deleted. Signed-off-by: Nicholas Seemiller <nseemiller@vmware.com>
seemiller
approved these changes
May 19, 2021
|
Got it, Thanks Jesse and Seemiller. |
|
@seemiller Thanks very much 👍 Regarding the multus package image URL in addons/repos/main.yaml, how can we get the SHA before merging this PR? Josh mentioned TCE team will push the image after PR is merged? |
We can update to caymanized multus cni image URL once it's ready. Currently all other addons use upstream default multus cni images.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Multus is a "meta" CNI that allows pods to have mulitple container network interfaces. It is typically required for Telco workloads so that SR-IOV and DPDK enabled devices can be connected as "secondary" interfaces.
This PR adds multus-cni as a new package to the main channel
Note: Do not merged, image path should be changed for both upstream and bundle
Which issue(s) this PR fixes
#584
Describe testing done for PR
Special notes for your reviewer
Does this PR introduce a user-facing change?