This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Fix condition check for presence of carvel tools #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format used by using a "placeholder" string in the check did not work everywhere. Since this is comparing the location of each tool we are looking for, it actually should be an empty string. Signed-off-by: Sean McGinnis <smcginnis@vmware.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The format used by using a "placeholder" string in the check did not
work everywhere. Since this is comparing the location of each tool we
are looking for, it actually should be an empty string.
Correct changes introduced in #515
Describe testing done for PR
Ran
make check-carvelon macOS and Linux, with carvel toolset present and not.