This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
akoo template bug fix #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmcb
approved these changes
Jun 8, 2021
There was a problem hiding this comment.
Hi @iXinqi - This looks good to me, but I see that this same package is being maintained in the core repository. I'm guessing this is in the process of being migrated to TCE? Just want to clarify to avoid misunderstanding. Thanks much!
|
Thanks @jpmcb for your comment. AKOO is added to core addon recently and we found a bug during e2e test. I have already merged the bug fix to core repo, so I made the same change here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as https://github.com/vmware-tanzu-private/core/pull/749