This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Enable the ability to create a release from a release branch #829
+22
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidvonthenen
changed the title
Update to tag script fix lint
davidvonthenen
force-pushed
the
handlereleasebranches
branch
from
c235966 to
d4fa802
Compare
jpmcb
approved these changes
Jun 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
There were improvements made in the
v0.5.0release for the release process and this PR should enable handling doing builds from a release branch which I would prefer namingrelease-0.5(for example) if we need to do bug fixes, patches, etc on a non-main release. This actually happens to match the branch format for thecorerepo (v1.3.X->release-1.3).Additionally:
rebuild-pluginandrebuild-all... just callbuildandbuild-allWhich issue(s) this PR fixes
Fixes: #555
Describe testing done for PR
I simulated the effects of the script on a different personal repo: https://github.com/dvonthenen/branchtest
After this gets merged, I'm going to push a "fake" tag for testing end to end.
Special notes for your reviewer
NA
Does this PR introduce a user-facing change?
No