This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Fix alertmanager config as secret instead of ConfigMap. Modify defaults for Grafana #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmcb
approved these changes
Jun 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Alertmanager:
Fix for alertmanager not sending any notifications. This is because alertmanager config is a kubernetes secret and not a configMap.
Grafana:
Modified grafana default values. Fixed values files per tobs naming conventions.
Which issue(s) this PR fixes
NA
Describe testing done for PR
Deployed prometheus/alertmanger and grafana on kind and verified all pods are running.
Special notes for your reviewer
NA
Does this PR introduce a user-facing change?
Na