-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COSMOS-893 Make graphql server as go binary directly to run , instead of loading as plugin #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramramu3433
force-pushed
the
npt-632-without-plugin
branch
from
March 23, 2023 12:58
7a9acc7
to
b173850
Compare
ramramu3433
force-pushed
the
npt-632-without-plugin
branch
from
March 24, 2023 09:01
b173850
to
018e146
Compare
vishnukavach
added a commit
that referenced
this pull request
May 12, 2023
… of loading as plugin (#139) * NPT-632: Cosmos DM nexus compiler changes * COSMOS-856 and COSMOS-858 Fix * Add new type * Fix graphql resolver * Add new type NexusGenericObject * add go pin version * use without plugin mode * Use upper case first letter for non global nodes * Use upper case first letter for field schema name * Add Node NotifyCallBack in nexus-client * Parse non nexus nodes and types and copy them to model dir --------- Co-authored-by: Vishnubabu <kvishnu@vmware.com> Co-authored-by: rjanakiraman <rjanakiraman@vmware.com> Co-authored-by: Kacper Sawicki <sawickik@vmware.com>
vishnukavach
added a commit
that referenced
this pull request
May 31, 2023
… of loading as plugin (#139) * NPT-632: Cosmos DM nexus compiler changes * COSMOS-856 and COSMOS-858 Fix * Add new type * Fix graphql resolver * Add new type NexusGenericObject * add go pin version * use without plugin mode * Use upper case first letter for non global nodes * Use upper case first letter for field schema name * Add Node NotifyCallBack in nexus-client * Parse non nexus nodes and types and copy them to model dir --------- Co-authored-by: Vishnubabu <kvishnu@vmware.com> Co-authored-by: rjanakiraman <rjanakiraman@vmware.com> Co-authored-by: Kacper Sawicki <sawickik@vmware.com>
vishnukavach
added a commit
that referenced
this pull request
May 31, 2023
… of loading as plugin (#139) * NPT-632: Cosmos DM nexus compiler changes * COSMOS-856 and COSMOS-858 Fix * Add new type * Fix graphql resolver * Add new type NexusGenericObject * add go pin version * use without plugin mode * Use upper case first letter for non global nodes * Use upper case first letter for field schema name * Add Node NotifyCallBack in nexus-client * Parse non nexus nodes and types and copy them to model dir --------- Co-authored-by: Vishnubabu <kvishnu@vmware.com> Co-authored-by: rjanakiraman <rjanakiraman@vmware.com> Co-authored-by: Kacper Sawicki <sawickik@vmware.com>
kacpersaw
added a commit
that referenced
this pull request
Jun 1, 2023
* NPT-632: Cosmos DM nexus compiler changes * COSMOS-856 and COSMOS-858 Fix * Add new type * Fix graphql resolver * Add new type NexusGenericObject * Use upper case first letter for non global nodes * Use upper case first letter for field schema name * Add Node NotifyCallBack in nexus-client * Add RegisterCB function * Parse non nexus nodes and types and copy them to model dir * upgrade client-go to v0.26.3 * upgrade client-go to v0.26.3 * Pin k8s client-go version * set apiextensions-apiserver as require * Update require k8s lib * COSMOS-893 Make graphql server as go binary directly to run , instead of loading as plugin (#139) * NPT-632: Cosmos DM nexus compiler changes * COSMOS-856 and COSMOS-858 Fix * Add new type * Fix graphql resolver * Add new type NexusGenericObject * add go pin version * use without plugin mode * Use upper case first letter for non global nodes * Use upper case first letter for field schema name * Add Node NotifyCallBack in nexus-client * Parse non nexus nodes and types and copy them to model dir --------- Co-authored-by: Vishnubabu <kvishnu@vmware.com> Co-authored-by: rjanakiraman <rjanakiraman@vmware.com> Co-authored-by: Kacper Sawicki <sawickik@vmware.com> * when commit pushed * Fatal node without parent * Fix GNS Plural issue * Fix plural issue GNS --> gnss * revert kacper non global changes * Reverted Plural fix and COSMOS Nexus Compiler version-1 * Bring in Plural Fix as version-2 * Fix issue in Delete{Node}ByName() method (#147) Co-authored-by: klokeshvar <klokeshvar@vmware.com> * Cleanup unused notify method * Skipping ignored dirs from config in preparser and node_parser * NPT-890: Modified RegisterCB return type * COSMOS-1507: Modified return type template nexus client * NPT-632 Cosmos datamodel non global packages support (#150) * Add new type * Use uppercase letter for package name in graphql * Fix non global & Makefile * Remove NexusType --------- Co-authored-by: Vishnubabu <kvishnu@vmware.com> * Fixed issue in graphql schema generation for non standard array type * Add ForceRead support * COSMOS-1557: Check if parent exist before calling callback func (#151) * Check if parent exist before calling callback * Add ForceRead support * Check if gvk exist, if not panic * Fix template * Update RegisterAddCallback template * Update RegisterAddCallback and add checks to RegisterDeleteCallback method --------- Co-authored-by: Vishnubabu <kvishnu@vmware.com> * Added singletone details in nexus directives * COSMOS-1557: Fix data race (#153) * Check if parent exist before calling callback * Add ForceRead support * Check if gvk exist, if not panic * Fix template * Update RegisterAddCallback template * Update RegisterAddCallback and add checks to RegisterDeleteCallback method * Fix data race --------- Co-authored-by: Vishnubabu <kvishnu@vmware.com> * Adding template for RegisterEventHandler (#154) Co-authored-by: klokeshvar <klokeshvar@vmware.com> * Bump go version * Pin cert-manager version * Fix problem with hardcoded Global() in nexus client * Fix typo * Use Parent's SimpleGroupName for force read * Organize imports * Organize imports, migrate depracated methods * Add logrus and template changes * rebase with main and removed connector api * Add retry on timeout and fix new context on canceled * COSMOS-2430: Add field Aggregator to fix GNS update issue * Fix tests * Modify example datamodel and render templates * Modify CI * Add error log * Modify CI * Modify CI * Fix tests * Render templates & fix dm example * Patch fail if node already exists * Add some debug with timestamp * Add some debug with timestamp new * Fix tests * Render templates * Fix tests * render templates * COSMOS-2065: Fixed Gvk * Fix typo * fix * cleanup * Fix IsAggregate method * Use reflect to detect aggregate type * Fix template * Remove IsAggregate method and related methods * Generate code * Render templates * Fix example tests * Go tidy example output go.mod file * Tidy example tests * COSMOS-2578: Add debug log and retry logic * COSMOS-2578: Fix * Create model.go only if it's not empty * Fix Makefile * Fix Makefile * Fix Makefile * Fix Makefile * Generate example * Generate example * Remove go.mod from nexus-gql * Fix Makefile nexus-gql * Fix Makefile and generate example * Render templates * Add UT's & generate example * Fix imports * Merge & generate example * Render templates * Fix nexus-client and generate example * Fix test-utils dm * Fix template_renderers.go --------- Co-authored-by: Vishnubabu <kvishnu@vmware.com> Co-authored-by: Janakiraman <ramramu.jr@gmail.com> Co-authored-by: rjanakiraman <rjanakiraman@vmware.com> Co-authored-by: Lokeshvar Kumar <36099411+LokeshvarKr@users.noreply.github.com> Co-authored-by: klokeshvar <klokeshvar@vmware.com> Co-authored-by: vipinakavarpu <vakavarpu@vmware.com>
vishnukavach
added a commit
that referenced
this pull request
Jun 15, 2023
… of loading as plugin (#139) * NPT-632: Cosmos DM nexus compiler changes * COSMOS-856 and COSMOS-858 Fix * Add new type * Fix graphql resolver * Add new type NexusGenericObject * add go pin version * use without plugin mode * Use upper case first letter for non global nodes * Use upper case first letter for field schema name * Add Node NotifyCallBack in nexus-client * Parse non nexus nodes and types and copy them to model dir --------- Co-authored-by: Vishnubabu <kvishnu@vmware.com> Co-authored-by: rjanakiraman <rjanakiraman@vmware.com> Co-authored-by: Kacper Sawicki <sawickik@vmware.com>
vishnukavach
added a commit
that referenced
this pull request
Jun 15, 2023
* NPT-632: Cosmos DM nexus compiler changes * COSMOS-856 and COSMOS-858 Fix * Add new type * Fix graphql resolver * Add new type NexusGenericObject * Use upper case first letter for non global nodes * Use upper case first letter for field schema name * Add Node NotifyCallBack in nexus-client * Add RegisterCB function * Parse non nexus nodes and types and copy them to model dir * upgrade client-go to v0.26.3 * upgrade client-go to v0.26.3 * Pin k8s client-go version * set apiextensions-apiserver as require * Update require k8s lib * COSMOS-893 Make graphql server as go binary directly to run , instead of loading as plugin (#139) * NPT-632: Cosmos DM nexus compiler changes * COSMOS-856 and COSMOS-858 Fix * Add new type * Fix graphql resolver * Add new type NexusGenericObject * add go pin version * use without plugin mode * Use upper case first letter for non global nodes * Use upper case first letter for field schema name * Add Node NotifyCallBack in nexus-client * Parse non nexus nodes and types and copy them to model dir --------- Co-authored-by: Vishnubabu <kvishnu@vmware.com> Co-authored-by: rjanakiraman <rjanakiraman@vmware.com> Co-authored-by: Kacper Sawicki <sawickik@vmware.com> * when commit pushed * Fatal node without parent * Fix GNS Plural issue * Fix plural issue GNS --> gnss * revert kacper non global changes * Reverted Plural fix and COSMOS Nexus Compiler version-1 * Bring in Plural Fix as version-2 * Fix issue in Delete{Node}ByName() method (#147) Co-authored-by: klokeshvar <klokeshvar@vmware.com> * Cleanup unused notify method * Skipping ignored dirs from config in preparser and node_parser * NPT-890: Modified RegisterCB return type * COSMOS-1507: Modified return type template nexus client * NPT-632 Cosmos datamodel non global packages support (#150) * Add new type * Use uppercase letter for package name in graphql * Fix non global & Makefile * Remove NexusType --------- Co-authored-by: Vishnubabu <kvishnu@vmware.com> * Fixed issue in graphql schema generation for non standard array type * Add ForceRead support * COSMOS-1557: Check if parent exist before calling callback func (#151) * Check if parent exist before calling callback * Add ForceRead support * Check if gvk exist, if not panic * Fix template * Update RegisterAddCallback template * Update RegisterAddCallback and add checks to RegisterDeleteCallback method --------- Co-authored-by: Vishnubabu <kvishnu@vmware.com> * Added singletone details in nexus directives * COSMOS-1557: Fix data race (#153) * Check if parent exist before calling callback * Add ForceRead support * Check if gvk exist, if not panic * Fix template * Update RegisterAddCallback template * Update RegisterAddCallback and add checks to RegisterDeleteCallback method * Fix data race --------- Co-authored-by: Vishnubabu <kvishnu@vmware.com> * Adding template for RegisterEventHandler (#154) Co-authored-by: klokeshvar <klokeshvar@vmware.com> * Bump go version * Pin cert-manager version * Fix problem with hardcoded Global() in nexus client * Fix typo * Use Parent's SimpleGroupName for force read * Organize imports * Organize imports, migrate depracated methods * Add logrus and template changes * rebase with main and removed connector api * Add retry on timeout and fix new context on canceled * COSMOS-2430: Add field Aggregator to fix GNS update issue * Fix tests * Modify example datamodel and render templates * Modify CI * Add error log * Modify CI * Modify CI * Fix tests * Render templates & fix dm example * Patch fail if node already exists * Add some debug with timestamp * Add some debug with timestamp new * Fix tests * Render templates * Fix tests * render templates * COSMOS-2065: Fixed Gvk * Fix typo * fix * cleanup * Fix IsAggregate method * Use reflect to detect aggregate type * Fix template * Remove IsAggregate method and related methods * Generate code * Render templates * Fix example tests * Go tidy example output go.mod file * Tidy example tests * COSMOS-2578: Add debug log and retry logic * COSMOS-2578: Fix * Create model.go only if it's not empty * Fix Makefile * Fix Makefile * Fix Makefile * Fix Makefile * Generate example * Generate example * Remove go.mod from nexus-gql * Fix Makefile nexus-gql * Fix Makefile and generate example * Render templates * Add UT's & generate example * Fix imports * Merge & generate example * Render templates * Fix nexus-client and generate example * Fix test-utils dm * Fix template_renderers.go --------- Co-authored-by: Vishnubabu <kvishnu@vmware.com> Co-authored-by: Janakiraman <ramramu.jr@gmail.com> Co-authored-by: rjanakiraman <rjanakiraman@vmware.com> Co-authored-by: Lokeshvar Kumar <36099411+LokeshvarKr@users.noreply.github.com> Co-authored-by: klokeshvar <klokeshvar@vmware.com> Co-authored-by: vipinakavarpu <vakavarpu@vmware.com>
vishnukavach
added a commit
that referenced
this pull request
Jun 15, 2023
* NPT-632: Cosmos DM nexus compiler changes * COSMOS-856 and COSMOS-858 Fix * Add Node NotifyCallBack in nexus-client * Add RegisterCB function * Parse non nexus nodes and types and copy them to model dir * upgrade client-go to v0.26.3 * Pin k8s client-go version * COSMOS-893 Make graphql server as go binary directly to run , instead of loading as plugin (#139) * NPT-632: Cosmos DM nexus compiler changes * Add Node NotifyCallBack in nexus-client * Fix GNS Plural issue * Update RegisterAddCallback and add checks to RegisterDeleteCallback method * COSMOS-2430: Add field Aggregator to fix GNS update issue * Fix issue in Delete{Node}ByName() method (#147) * NPT-632 Cosmos datamodel non global packages support (#150) * COSMOS-1557: Check if parent exist before calling callback func (#151) * COSMOS-1557: Fix data race (#153) * Adding template for RegisterEventHandler (#154) * NPT-632 Unit tests (#186) * COSMOS-2804: Nexus SDK should be able to infer the annotations and labels needs it and not need the app code to populate them (#191) * COSMOS-2578: Add debug log and retry logic --------- Co-authored-by: Kacper Sawicki <sawickik@vmware.com> Co-authored-by: klokeshvar <klokeshvar@vmware.com> Co-authored-by: Vishnubabu <kvishnu@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.