Skip to content

Commit

Permalink
Restore test, fix apprepository-rbac (#1610)
Browse files Browse the repository at this point in the history
  • Loading branch information
Andres Martinez Gotor authored Mar 26, 2020
1 parent a7c7ad1 commit 80be45f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
2 changes: 1 addition & 1 deletion chart/kubeapps/templates/apprepository-rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ rules:
- secrets
verbs:
- create
{{- end -}}
{{ end }}
{{- if .Values.featureFlags.reposPerNamespace -}}
---
# Kubeapps can read and watch its own AppRepository resources cluster-wide.
Expand Down
10 changes: 2 additions & 8 deletions integration/use-cases/create-registry.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,12 @@ test("Creates a registry", async () => {
// the Install Repo doesn't always register (in fact, from the
// screenshot on failure, it appears to focus the button only (hover css applied)
await expect(page).toClick("button", { text: "Install Repo" });

try {
await expect(page).toClick("a", { text: "my-repo" });
} catch (e) {
await expect(page).toClick("button", { text: "Install Repo" });
await expect(page).toMatch("Install Repo");
}
await expect(page).toClick("a", { text: "my-repo" });

let retries = 3;
while (retries > 0) {
try {
await expect(page).toMatch("gitlab", { timeout: 2000 });
await expect(page).toMatch("gitlab-runner", { timeout: 2000 });
break;
} catch (e) {
// Refresh since the chart will get a bit of time to populate
Expand Down

0 comments on commit 80be45f

Please sign in to comment.