Revert to select the chart version of the current release on upgrade (#…

…1411)

dashboard/src/components/UpgradeForm/UpgradeForm.test.tsx

@@ -67,6 +67,17 @@ it("renders the full UpgradeForm", () => {
   expect(wrapper).toMatchSnapshot();
 });
 
+it("defaults the upgrade version to the current version", () => {
+  // helm upgrade is the only way to update the values.yaml, so upgrade is
+  // often used by users to update values only, so we can't default to the
+  // latest version on the assumption that they always want to upgrade.
+  const wrapper = shallow(
+    <UpgradeForm {...defaultProps} selected={{ versions, version: versions[0] }} />,
+  );
+
+  expect(wrapper.find(DeploymentFormBody).prop("chartVersion")).toBe("1.0.0");
+});
+
 it("forwards the appValues when modified", () => {
   const wrapper = shallow(<UpgradeForm {...defaultProps} />);
   const handleValuesChange: (v: string) => void = wrapper

dashboard/src/components/UpgradeForm/UpgradeForm.tsx

@@ -92,7 +92,7 @@ class UpgradeForm extends React.Component<IUpgradeFormProps, IUpgradeFormState>
           <div className="col-8">
             <DeploymentFormBody
               chartID={chartID}
-              chartVersion={this.props.selected.versions[0].attributes.version}
+              chartVersion={this.props.appCurrentVersion}
               deployedValues={this.props.appCurrentValues || ""}
               namespace={this.props.namespace}
               releaseVersion={this.props.appCurrentVersion}

dashboard/src/components/UpgradeForm/__snapshots__/UpgradeForm.test.tsx.snap

@@ -28,7 +28,7 @@ exports[`renders the full UpgradeForm 1`] = `
       <DeploymentFormBody
         appValues="foo: bar"
         chartID="my-repo/my-chart"
-        chartVersion="1.2.3"
+        chartVersion="1.0.0"
         deployedValues="foo: bar"
         getChartVersion={[Function]}
         goBack={[Function]}