Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation is off for apprepository definition #1271

Closed
davidkarlsen opened this issue Nov 5, 2019 · 0 comments
Closed

Indentation is off for apprepository definition #1271

davidkarlsen opened this issue Nov 5, 2019 · 0 comments

Comments

@davidkarlsen
Copy link
Contributor

davidkarlsen commented Nov 5, 2019

Indent for securityContext in https://github.com/kubeapps/kubeapps/blob/master/chart/kubeapps/templates/apprepositories.yaml#L30 is off. The resulting rendered resource will look like:

apiVersion: kubeapps.com/v1alpha1
kind: AppRepository
metadata:
  annotations:
    helm.sh/hook: crd-install
    helm.sh/hook-weight: "10"
  creationTimestamp: "2019-08-10T21:25:44Z"
  generation: 1
  labels:
    app: kubeapps-internal-apprepository-controller
    chart: kubeapps-2.0.3
    heritage: Tiller
    release: kubeapps
  name: evryfs
  namespace: kubeapps
  resourceVersion: "78566"
  selfLink: /apis/kubeapps.com/v1alpha1/namespaces/kubeapps/apprepositories/evryfs
  uid: 69506a52-bbb5-11e9-b168-005056b8160d
spec:
  syncJobPodTemplate:
    spec:
      runAsUser: 1001
      securityContext: null
  type: helm
  url: https://myrepo.com/nexus/repository/evryfs-helm/
davidkarlsen added a commit to davidkarlsen/kubeapps that referenced this issue Nov 5, 2019
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant