Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinniped-proxy should cache credentials for lifetime of credential request #2875

Closed
absoludity opened this issue May 24, 2021 · 2 comments · Fixed by #4918
Closed

pinniped-proxy should cache credentials for lifetime of credential request #2875

absoludity opened this issue May 24, 2021 · 2 comments · Fixed by #4918
Assignees
Labels
component/pinniped-proxy Issue related to kubeapps integration with pinniped-proxy kind/feature An issue that reports a feature (approved) to be implemented

Comments

@absoludity
Copy link
Contributor

Description:

When initially creating the pinniped-proxy service, we had planned to cache the response of the token credential request and re-use it for subsequent requests.

As it is, it worked OK without this initially, but it is still overkill to be doing so for every request, and may be too slow in the future when pinniped tries to use the certificate signing requests API.

@absoludity absoludity added kind/feature An issue that reports a feature (approved) to be implemented priority/low component/pinniped-proxy Issue related to kubeapps integration with pinniped-proxy labels May 24, 2021
@viktor-haag
Copy link

Continuing the discussion we had in #2363, I have one more observation which might help. From what I could see, it seem that requests to /api/clusters/default/api/v1 and /api/clusters/default/api/v1/namespaces/ always run into the 60s timeout. Aside from that, the response time of the other api calls is pretty inconsistant. If I directly hit one of the apis via the browser I get in extreme cases an instant response but am also as likely to run into the 60s timeout.

Aside from that, is there a combination of Kubeapps and Pinniped versions which you could recommend? I'd try a fresh install and check if the problem still persists there.

@antgamdia
Copy link
Contributor

Thanks for your comments. It is something we have to investigate.

wrt your question:
Kubeapps 2.3.2 is compatible with Pinniped >= v6.0.0 (latest is now 0.9.2)
Kubeapps 2.3.3 is compatuble with any Pinniped version (including < v6.0.0)

Apart from that, there are no extra requirements on the versions.

@ppbaena ppbaena added this to the Technical debt milestone Sep 24, 2021
@ppbaena ppbaena added this to Kubeapps Mar 9, 2022
@ppbaena ppbaena moved this to 🗂. Backlog in Kubeapps Mar 9, 2022
@ppbaena ppbaena added this to Kubeapps Mar 31, 2022
@ppbaena ppbaena moved this to 🗂 Backlog in Kubeapps Mar 31, 2022
@absoludity absoludity added the next-iteration Issues to be discussed in planning session label Jun 6, 2022
@ppbaena ppbaena moved this from 🗂 Backlog to 🗒 Todo in Kubeapps Jun 6, 2022
@ppbaena ppbaena removed the next-iteration Issues to be discussed in planning session label Jun 6, 2022
Repository owner moved this from 🗂. Backlog to ✅. Done in Kubeapps Jun 14, 2022
Repository owner moved this from 🗒 Todo to ✅ Done in Kubeapps Jun 14, 2022
@absoludity absoludity self-assigned this Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/pinniped-proxy Issue related to kubeapps integration with pinniped-proxy kind/feature An issue that reports a feature (approved) to be implemented
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants