Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pinniped-proxy] Create identity cert directly from x509. #4860

Merged
merged 2 commits into from
Jun 8, 2022
Merged

[pinniped-proxy] Create identity cert directly from x509. #4860

merged 2 commits into from
Jun 8, 2022

Conversation

absoludity
Copy link
Contributor

Signed-off-by: Michael Nelson minelson@vmware.com

Description of the change

Just a fly-by while getting setup with pinniped-proxy locally again, this PR does 3 things:

  • Updates to use the latest pinniped version (0.17.0) in our dev environment
  • Updates the dev environment targets to allow creating a single-cluster environment
  • Simplifies the identity_for_exchange now that the underlying native_tls::Identity supports creating an identity cert directly from an x509.

Benefits

Simpler code, easier dev env.

Possible drawbacks

Applicable issues

Additional information

Although I've tested in real life, I'm keen to see if it's trivial to add a unit test for this also, so leaving in draft until I've tried.

@absoludity
Create identity cert directly from x509.
9a18f95 
Signed-off-by: Michael Nelson <minelson@vmware.com>
@netlify
Copy link

netlify bot commented Jun 7, 2022 •
edited
Loading

✅ Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit 845046c
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/62a00df1ba2ffb000800459b

antgamdia
antgamdia approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Nice to see the logic can be simplified now! Thanks

@absoludity
Add unit test for identy_for_exchange.
845046c 
Signed-off-by: Michael Nelson <minelson@vmware.com>
@absoludity absoludity marked this pull request as ready for review June 8, 2022 02:48
@absoludity
Copy link
Contributor Author

Great! Nice to see the logic can be simplified now! Thanks

Thanks. Added the unit tests.

@absoludity absoludity merged commit d74c1a8 into main Jun 8, 2022
@absoludity absoludity deleted the 2875-cache-pinniped-creds branch June 8, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antgamdia antgamdia antgamdia approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@absoludity @antgamdia @vmwclabot