Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for activeDeadlineSeconds extraFlag for AppRepository CronJobs #6966

Closed
rophy opened this issue Oct 18, 2023 · 1 comment
Closed

Support for activeDeadlineSeconds extraFlag for AppRepository CronJobs #6966

rophy opened this issue Oct 18, 2023 · 1 comment
Assignees
@rophy
Labels
kind/proposal An issue that reports a new feature proposal to be discussed

Comments

@rophy
Copy link
Contributor

rophy commented Oct 18, 2023

Summary

I see ttlSecondsAfterFinished is supported as an extraFlags. Can we add the same for activeDeadlineSeconds?

Background and rationale

Some kubernetes clusters may require CronJob to define activeDeadlineSeconds.

Acceptance criteria

Able to define activeDeadlineSeconds in .Values.apprepository.extraFlags, which gets added to result CronJob of AppRepository.
@rophy rophy added the kind/proposal An issue that reports a new feature proposal to be discussed label Oct 18, 2023
@rophy rophy mentioned this issue Oct 18, 2023
Merged
@github-project-automation github-project-automation bot moved this to 🗂 Backlog in Kubeapps Oct 19, 2023
@absoludity absoludity moved this from 🗂 Backlog to 🏗 In Progress in Kubeapps Oct 19, 2023
@absoludity
Copy link
Contributor

Thanks @rophy - makes sense. Assigning to you since you've already done a PR ... I'll add more feedback there.

absoludity added a commit that referenced this issue Oct 19, 2023
@rophy @absoludity
Support activeDeadlineSeconds for apprepository-controller (#6967)
181e686 
### Description of the change

Implements #6966 

### Benefits

AppRepository CronJobs supports
[activeDeadlineSeconds](https://kubernetes.io/docs/concepts/workloads/controllers/job/#job-termination-and-cleanup)

### Possible drawbacks

I'm not a golang developer, `go test` passed, not sure if there is
anything else I should be testing?

### Applicable issues

#6966

---------

Signed-off-by: Michael Nelson <minelson@vmware.com>
Co-authored-by: Michael Nelson <minelson@vmware.com>
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in Kubeapps Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rophy rophy

Labels
kind/proposal An issue that reports a new feature proposal to be discussed
Projects
Kubeapps
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@absoludity @rophy