Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.json parsing issues seem to be swallowed #892

Closed
prydonius opened this issue Dec 19, 2018 · 0 comments
Closed

config.json parsing issues seem to be swallowed #892

prydonius opened this issue Dec 19, 2018 · 0 comments
Assignees

Comments

@prydonius
Copy link
Contributor

#891 fixed a syntax error in the config.json file that was causing deployments to fail, but we didn't easily figure out that it was due to the syntax error in that file. We should easily be able to detect parsing errors for that file and bubble them up so they are more noticeable. See also https://kubernetes.slack.com/archives/C9D3TSUG4/p1545178666065400.

Looks to me like axios is swallowing the error up: https://github.com/kubeapps/kubeapps/blob/490b316eb9df7d070fef7442fc5736d60d018175/dashboard/src/shared/Config.ts#L12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants