Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config.json #891

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Fix config.json #891

merged 1 commit into from
Dec 19, 2018

Conversation

migmartri
Copy link
Contributor

@migmartri migmartri commented Dec 19, 2018 •
edited
Loading

Apps fail to deploy due to a syntax error in the config file in the chart.

Refs #608

prydonius
prydonius approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@migmartri migmartri requested a review from andresmgot December 19, 2018 00:25
@migmartri migmartri merged commit 890ec4f into vmware-tanzu:master Dec 19, 2018
@migmartri migmartri deleted the fix-versioning branch December 19, 2018 00:26
@prydonius prydonius mentioned this pull request Dec 19, 2018
Closed
@andresmgot
Copy link
Contributor

Thanks! (and sorry for not seeing that)

@migmartri
Copy link
Contributor Author

Thanks! (and sorry for not seeing that)

No problem.

It was not easy to find. The UI seemed to work fine until we did a deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prydonius prydonius prydonius approved these changes

@andresmgot andresmgot Awaiting requested review from andresmgot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@migmartri @andresmgot @prydonius