-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the base64 decoding command in the documentation #917
Comments
thanks for the tip, do you know what version of kubectl added this? I think we didn't document |
I don't remember. I think is was 1.11, but don't quote me. :) If your worried about 1.9+, then its a no go. |
I think at that point we cared about 1.8 support because the supported versions were 1.8-1.10. With 1.13, it wouldn't necessarily be bad to require 1.11+, especially since |
+1 I can confirm it is 1.11+. I found a 1.10 laying around and it doesnt work, but does in 1.11. |
Thanks for confirming! cc @kubeapps/maintainers, what do you think? |
This is great, thanks @kfox1111 for reporting it! @prydonius. The issue to me is not requiring 1.11+ is explaining the fact that we do. Is this the only platform specific command in our docs? If it is, I agree with going forward now by adding the new syntax, we might want to keep both for some time though. |
We can fix this now. Kubernetes 1.11 has been out for a while. |
Very minor tweak. in the docs, rather then this:
-o jsonpath='{.data.token}' | base64 --decode
you can do:
-o go-template='{{.data.token | base64decode}}'
It should work on all platforms as its built into kubectl now.
The text was updated successfully, but these errors were encountered: