Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve base64 decoding command usage in docs #1191

Merged
merged 4 commits into from
Sep 30, 2019
Merged

Improve base64 decoding command usage in docs #1191

merged 4 commits into from
Sep 30, 2019

Conversation

Dean-Coakley
Copy link
Contributor

Fixes: #917

Proposed changes:

  • Use builtin base64decode command that is included in kubectl, previously docs were piping output to base64 --decode command.
  • Add bash syntax highlighting to - docs/user/access-control.md

Let me know if you want to drop any changes or make any improvements.

andresmgot
andresmgot approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs @Dean-Coakley! I have a couple of small comments to improve it a bit more.

docs/developer/chart-repo.md Show resolved Hide resolved
docs/user/access-control.md Outdated Show resolved Hide resolved
@andresmgot andresmgot merged commit a05d046 into vmware-tanzu:master Sep 30, 2019
@Dean-Coakley Dean-Coakley deleted the improve-base64-docs branch September 30, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresmgot andresmgot andresmgot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the base64 decoding command in the documentation
2 participants
@Dean-Coakley @andresmgot