Catch possible errors with incomplete Ingress objects #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prydonius
approved these changes
May 29, 2019
| @@ -38,6 +38,27 @@ describe("GetURLItemFromIngress", () => { | |||
| tlsHosts: ["foo.bar"], | |||
| expectedURLs: ["https://foo.bar", "http://not-foo.bar"], | |||
| }, | |||
| { | |||
| description: "it should ignore an ingress if it has no hosts", | |||
There was a problem hiding this comment.
Does this still show an entry for the Ingress in the AccessURLTable, though without any clickable links? I think we'd still want to show that an Ingress exists, but that the hosts are not correctly defined.
There was a problem hiding this comment.
sorry, this test is misleading, hosts is not a valid field in an ingress so I am adding a test for the test code 😅
In any case, I have just realized two new cases: when an ingress has no rules and when a rule has no host. I am adding test cases for those. For the first it should return an error, for the second we should catch the host as a wildcard (not undefined).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1040
Ensure that an Ingress object has
rules,pathsandtls.hostsdefined before processing them to avoid errors.