Fix memory usage for tiller-proxy #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prydonius
reviewed
Jun 19, 2019
pkg/chart/chart.go
Outdated
| if err != nil { | ||
| return index, err | ||
| func checksum(data []byte) string { | ||
| hasher := sha1.New() |
There was a problem hiding this comment.
any reason we want to use sha1 and not sha256?
There was a problem hiding this comment.
I assumed it was faster but I guess it's not really needed
| } | ||
|
|
||
| func parseIndex(repoURL string, data []byte) (*repo.IndexFile, error) { | ||
| sha := checksum(data) |
There was a problem hiding this comment.
I'm not sure the cache check should be part of parseIndex, it would make more sense if we checked the cache in a separate function before parseIndex.
Added now that it has its own function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1052
Cache the result of unmarshaling the
index.yamlfile of a repository.Increase the memory limit for Tiller-proxy.