Refactor tables in the AppView #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 21, 2019 15:59
andresmgot
commented
Jun 21, 2019
| case "Service": | ||
| return <ServiceItem resource={resource.item} />; | ||
| case "Secret": | ||
| // TODO: Set double type |
There was a problem hiding this comment.
I need to change the type here
| resourceRefs: ResourceRef[]; | ||
| } | ||
|
|
||
| class WorkloadTable extends React.Component<IWorkloadItemTableProps> { |
prydonius
reviewed
Jun 21, 2019
| return <ServiceItem resource={resource.item} />; | ||
| case "Secret": | ||
| // TODO: Set double type | ||
| const i = (resource.item as any) as ISecret; |
There was a problem hiding this comment.
hmm maybe SecretItem should just accept IResource and internally change it to ISecret?
There was a problem hiding this comment.
I would see it weird for the SecretItem to accept a IResource when it only works for an ISecret. It's better to do the conversion before. It's actually the generic "TableItem" the one that can receive different types of resources.
There was a problem hiding this comment.
You're right, I was just thinking this given that ServiceItem and other resources look like they accept IResources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #848
Refactor common code used by the different tables in the AppView: WorkloadTable, ServiceTable, SecretsTable and OtherResourcesTable.
Now everything is a
ResourceTableand depending on the type of the resource (kind) it renders a different type of row.