-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Doc for using Harbor as Helm chart repository #1075
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the guide! I just have a couple of questions
|
||
To use Harbor with Kubeapps, first deploy Harbor using [Harbor offline installer](https://github.com/goharbor/harbor/blob/master/docs/installation_guide.md#downloading-the-installer). Here are the minimum steps required on a Linux machine to install Harbor for serving as Helm Chart Repository. | ||
``` | ||
$ wget https://storage.googleapis.com/harbor-releases/release-1.8.0/harbor-offline-installer-v1.8.1.tgz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference between using this method or using the helm chart from https://github.com/goharbor/harbor-helm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both offline-installer and Harbor helm chart work well. I just tried the offline-installer way which is easy to use and doesn't require k8s. BTW the release of Harbor helm chart will be a little behind the release of Harbor offline-installer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you mention the chart then too? It's not necessary to explain all the other steps but for example for me it's easier to deploy the chart and use the k8s Service to access the service rather than an IP. Just to let users know that's also an option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, good suggestion. I have pushed the change which includes Harbor Helm Chart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add the detail guide for deploying Harbor Helm Chart in future.
$ wget https://storage.googleapis.com/harbor-releases/release-1.8.0/harbor-offline-installer-v1.8.1.tgz | ||
$ tar xvf harbor-offline-installer-v1.8.1.tgz | ||
$ cd harbor | ||
$ sed -i 's/hostname: reg.mydomain.com/hostname: <Current-Machine-IP>/' harbor.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain how you can get this Current-Machine-IP
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since "Here are the minimum steps required on a Linux machine to install Harbor", the Current-Machine-IP
means the IP of this Linux machine. We can run ifconfig to get its IP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for the guide!
This is great, thanks for the contribution :) It might make sense to document how to configure authentication since in other providers we do so. i.e a new section called I'd also sort the providers alphabetically. Artifactory, ChartMuseum, Harbor. |
@migmartri Sure, I will add a new section |
Thanks @jessehu!
Good point, ignore my comment then :) |
Fix #1069.