Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Doc for using Harbor as Helm chart repository #1075

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

jessehu
Copy link
Contributor

@jessehu jessehu commented Jul 7, 2019

Fix #1069.

Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the guide! I just have a couple of questions


To use Harbor with Kubeapps, first deploy Harbor using [Harbor offline installer](https://github.com/goharbor/harbor/blob/master/docs/installation_guide.md#downloading-the-installer). Here are the minimum steps required on a Linux machine to install Harbor for serving as Helm Chart Repository.
```
$ wget https://storage.googleapis.com/harbor-releases/release-1.8.0/harbor-offline-installer-v1.8.1.tgz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference between using this method or using the helm chart from https://github.com/goharbor/harbor-helm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both offline-installer and Harbor helm chart work well. I just tried the offline-installer way which is easy to use and doesn't require k8s. BTW the release of Harbor helm chart will be a little behind the release of Harbor offline-installer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mention the chart then too? It's not necessary to explain all the other steps but for example for me it's easier to deploy the chart and use the k8s Service to access the service rather than an IP. Just to let users know that's also an option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, good suggestion. I have pushed the change which includes Harbor Helm Chart.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add the detail guide for deploying Harbor Helm Chart in future.

$ wget https://storage.googleapis.com/harbor-releases/release-1.8.0/harbor-offline-installer-v1.8.1.tgz
$ tar xvf harbor-offline-installer-v1.8.1.tgz
$ cd harbor
$ sed -i 's/hostname: reg.mydomain.com/hostname: <Current-Machine-IP>/' harbor.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain how you can get this Current-Machine-IP?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since "Here are the minimum steps required on a Linux machine to install Harbor", the Current-Machine-IP means the IP of this Linux machine. We can run ifconfig to get its IP.

Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the guide!

@andresmgot andresmgot merged commit c4baec3 into vmware-tanzu:master Jul 8, 2019
@migmartri
Copy link
Contributor

migmartri commented Jul 10, 2019

This is great, thanks for the contribution :)

It might make sense to document how to configure authentication since in other providers we do so. i.e a new section called Harbor Authentication/Authorization

I'd also sort the providers alphabetically. Artifactory, ChartMuseum, Harbor.

@jessehu
Copy link
Contributor Author

jessehu commented Jul 11, 2019

@migmartri Sure, I will add a new section Harbor Authentication/Authorization. The private project in Harbor requires authentication, while the public project doesn't.
The order of current 3 providers might be due to ChartMuseum and Harbor are both open source projects, and JFrog Artifactory Pro is a commercial product. JFrog Artifactory Open Source edition doesn't support Helm Chart repository.

@migmartri
Copy link
Contributor

Thanks @jessehu!

The order of current 3 providers might be due to ChartMuseum and Harbor are both open source projects, and JFrog Artifactory Pro is a commercial product. JFrog Artifactory Open Source edition doesn't support Helm Chart repository.

Good point, ignore my comment then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to use Harbor with Kubeapps
3 participants