Add tests for InitNetClient. Refactor to pass chart details #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
approved these changes
Aug 19, 2019
andresmgot
reviewed
Aug 19, 2019
| @@ -311,7 +313,11 @@ func (c *Chart) InitNetClient(customCA *CustomCA) (HTTPClient, error) { | |||
| } | |||
There was a problem hiding this comment.
not related to your changes but re-reading this I think we should return the error (as you added) instead of logging a fatal error.
There was a problem hiding this comment.
Woah, most definitely. I'll do that and the one I actually meant (up on 301 above), in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next small installment for #1110 .
I'm planning to have
InitNetClientfetching theAppRepositorycustom resource, when present in the request, but wasn't confident to change it before adding tests. So this PR just tests the existing functionality, with a tiny refactor to pass theChartDetailsinto the call (as this will include the auth object for the currentDetails.Auth.CustomCAsecret ref, as well as theDetails.AppRepository.ResourceNamewhich I'll pull from k8s and parse in a later PR).I have one other small prep branch next, before I'll add the fetch of the custom resource in
InitNetClient.