Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for integer and boolean params #1207

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Conversation

andresmgot
Copy link
Contributor

Ref #1182

This PR adds support to two new type of params (generic): integer and boolean:

Screenshot from 2019-10-07 14-55-54

The switch button is added with the package react-switch. The StringParam has been renamed to TextParam so it covers the use case for a number.

Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andresmgot andresmgot merged commit 0151477 into master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants