Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some param bugs when the value is undefined #1215

Merged
merged 3 commits into from
Oct 14, 2019
Merged

Fix some param bugs when the value is undefined #1215

merged 3 commits into from
Oct 14, 2019

Conversation

andresmgot
Copy link
Contributor

No description provided.

absoludity
absoludity approved these changes Oct 13, 2019
View reviewed changes
Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little unsure about using min as default for the slider... is it not possible to require a value for the slider? If not, then I agree min is a good default.

@andresmgot
Copy link
Contributor Author

I'm a little unsure about using min as default for the slider... is it not possible to require a value for the slider? If not, then I agree min is a good default.

Unfortunately, it's not. Neither the value in the values.yaml nor the default in the schema are mandatory.

@andresmgot andresmgot merged commit 111b88c into vmware-tanzu:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absoludity absoludity absoludity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresmgot @absoludity