Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style changes for basic form #1222

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Conversation

andresmgot
Copy link
Contributor

I have added some minor changes to the style of the basic form:

  • Added margin and separators between parameters
  • Display the label and input in the same line

Before:

Screenshot from 2019-10-15 12-25-53

After:

Screenshot from 2019-10-15 12-25-23

Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was this with the feedback from Angel?

@andresmgot
Copy link
Contributor Author

Was this with the feedback from Angel?

He agreed with the approach.

One minor thing he suggested was to increase the "step" size of the slider (like for example 128Mi for the memory instead of one by one). I tried that but the problem is that it breaks the current implementation for the input box in the slider. In that case, if you start typing "2" (because you want to write "256"), it handles 2 as a real value but since it's not a multiple of 128 it gets automatically changed to 128 so you cannot really write the value that you want.

That's probably something fixable but not trivial so I let that as a possibility for the future. For the rest, we are good to go for a first version and start gathering feedback.

@andresmgot andresmgot merged commit 91f44b0 into vmware-tanzu:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants