Make the slider param customizable via the schema

[andresmgot]

Ref: #1182

In order to avoid dependencies with hardcoded references to key names in the logic, I have set some new properties that an element can define in order to be rendered as a slider (instead of a string). For example, the disk size can be represented as:

        "size": { 
          "type": "string",
          "title": "Disk Size",
          "form": "diskSize",
          "render": "slider",
          "sliderMin": 1,
          "sliderMax": 100,
          "sliderUnit": "Gi"
        }

[absoludity]

So this is a string in the schema because it includes the units right? (ie. "10Gi") And it is parsed by helm as a string with units?

Makes this a bit awkward but I don't see a better option.

[andresmgot]

Exactly, that's why it's a string. You can actually go to the Advance tab and write 10000Mi if you want.

[absoludity]

Why do we need these in addition to the already-present minimum and maximum?

[andresmgot]

I tried that but the problem is that if a parameter contains minimum or maximum, it has precedence over the type. This means that it will always fail because it expect the field to be a integer instead of a string. Also the meaning is a bit different. This value is used to set the min and max values for the slider but you are actually allowed to write a bigger number if you want in the input box.

[absoludity]

So the awkwardness is that we have a generic param interface which is having fields added for specifics. Is it possible instead to compose a new IBasicFormNumberWithUnitsStringParam which includes IBasicFormParam as well as minimum, maximum, `units'?

My head isn't in this code deeply enough to see if that would avoid the awkwardness or make it more convoluted - so just see what you think.

[andresmgot]

that would be more difficult to handle from the code point of view. In that case, the type of the parameters will be IBasicFormParam | IBasicFormNumberWithUnitsStringParam, which make it more difficult because it require type conversions and assumptions. IMO, it's easier to handle as optional parameters.

[acim]

It would be nice to be able define a step here as well so that one may select 1, 3 or 5 instances of some lead election service.

[andresmgot]

agree, can you open a separate issue @acim so we don't forget?