Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint to basic form #1229

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Add hint to basic form #1229

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc79361
Add hint to basic form
Oct 16, 2019
9f8a983
Merge branch 'master' into basicHint
Oct 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dashboard/src/components/DeploymentFormBody/DeploymentFormBody.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ describe("when the basic form is enabled", () => {

const tab = wrapper
.find(Tab)
.findWhere(t => t.text() === "Basic")
.findWhere(t => !!t.text().match("Basic"))
.first();
tab.simulate("click");

Expand Down
15 changes: 14 additions & 1 deletion dashboard/src/components/DeploymentFormBody/DeploymentFormBody.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { retrieveBasicFormParams, setValue } from "../../shared/schema";
import { IBasicFormParam, IChartState } from "../../shared/types";
import { getValueFromEvent } from "../../shared/utils";
import { ErrorSelector } from "../ErrorAlert";
import Hint from "../Hint";
import LoadingWrapper from "../LoadingWrapper";
import AdvancedDeploymentForm from "./AdvancedDeploymentForm";
import BasicDeploymentForm from "./BasicDeploymentForm";
Expand Down Expand Up @@ -178,7 +179,19 @@ class DeploymentFormBody extends React.Component<
<div className="margin-t-normal">
<Tabs>
<TabList>
<Tab onClick={this.refreshBasicParameters}>Basic</Tab>
<Tab onClick={this.refreshBasicParameters}>
Basic{" "}
<Hint reactTooltipOpts={{ delayHide: 100 }} id="basicFormHelp">
<span>
This form has been automatically generated based on the chart schema.
<br />
This feature is currently in a beta state. If you find an issue please report it{" "}
<a target="_blank" href="https://github.com/kubeapps/kubeapps/issues/new">
here.
</a>
</span>
</Hint>
</Tab>
<Tab>Advanced</Tab>
</TabList>
<TabPanel>
Expand Down