Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openshift helpers - with this ghost can be deployed. #1230

Merged
merged 3 commits into from
Oct 17, 2019

Conversation

absoludity
Copy link
Contributor

@absoludity absoludity commented Oct 17, 2019

With this change I can deploy kubeapps successfully and use kubeapps to deploy Ghost (which has non-root images).

I can't deploy wordpress due to https://github.com/bitnami/bitnami-docker-wordpress/issues/127 , and deploying ghost locally requires the following value overrides:

ghostHost: localhost
securityContext:
  - fsGroup: 1000050000
  - fsUser: 1000050000
mariadb:
  securityContext:
    - fsGroup: 1000050000
    - fsUser: 1000050000
  persistence:
    enabled: false
persistence:
  enabled: false

(though I see on #676 that I can use securityContext: false instead - I'll try that too)

So not ideal, but:
ghost-on-minishift
\o/

Still to come:

  • Documentation
  • Update to test deploying with non cluster-admin user
  • Update tiller service account to not use cluster-admin

ref: #676

@absoludity absoludity requested a review from andresmgot October 17, 2019 05:23
@absoludity absoludity self-assigned this Oct 17, 2019
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! let me know if you find any blocker

chartsvc:
replicaCount: 1
dashboard:
replicaCount: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are missing the last line

Comment on lines +49 to +50
chart/kubeapps/charts/mongodb-%.tgz:
helm dep update ./chart/kubeapps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why you need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise if someone pulls our Kubeapps repo and runs make openshift-kubeapps it fails because it's deploying the chart from the current branch, which won't include the chart deps initially.

@absoludity absoludity merged commit 137b629 into vmware-tanzu:master Oct 17, 2019
@absoludity absoludity deleted the openshift-example-pt2 branch October 17, 2019 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants