Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify usingOIDCToken in Auth module #1231

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

SimonAlling
Copy link
Contributor

Another nice (indirect) consequence of this PR is that I now have the test suite up and running. 😃

Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoah - that was a little convoluted. Are you actually using the OIDC support? If so, just note that I'm currently looking to switch to use oauth2-proxy in #1199

@andresmgot andresmgot merged commit 3cfdd9f into vmware-tanzu:master Oct 17, 2019
@SimonAlling
Copy link
Contributor Author

Whoah - that was a little convoluted. Are you actually using the OIDC support? If so, just note that I'm currently looking to switch to use oauth2-proxy in #1199

I think we are, but I'm just now starting to discover kubeapps, hehe. I don't know whether your PR is relevant to us, but @lindhe might know.

@SimonAlling SimonAlling deleted the usingOIDCToken branch October 17, 2019 15:17
@absoludity
Copy link
Contributor

It shouldn't be relevant for any development work you're doing for helm 3 ( given that the authn method shouldn't impact that) - I just wasn't sure whether you were using it in your actual deployment (and just wanted to give a heads-up about the change :) )

@lindhe
Copy link
Contributor

lindhe commented Oct 18, 2019

We are using OIDC in our current deployment of Kubeapps. But we are not looking to change that with the Helm 3 development. The reason for looking into that part now is just for getting a feel for how the code is structured, tested etc.

However, I do expect that we will need to tinker around a bit with authentication. Particularly, I suspect that we will need to implement some sort of user profile system. But we'll see about that. And it shouldn't have much to do with OIDC anyhow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants