Frontend injects wsprotocols only when not using oidc authn #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
approved these changes
Oct 21, 2019
|
Great, thank you! Let's merge the two PRs |
absoludity
force-pushed
the
oauth2_proxy-test-websockets
branch
from
2320a93 to
1282b0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on from #1199. When QAing #1199, we noted that the websocket requests were 400ing. This was because with 1199, I've switched to no longer white-list requests to the k8s api, so they are sent via the proxy. The proxy handles adding any required auth headers for all requests (websocket requests included).
With this change, they upgrade without issue:
While there, I also removed the specific (key-cloak-based) cookie name which I'd added because I thought it would be referenced in the frontend and need updating there. Turns out its not at all, so we can just let
oauth2-proxyuse its default cookie name and avoid any confusion.