New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix browser tests #1262

Merged

andresmgot merged 4 commits into master from fixBrowserTests

Oct 30, 2019

Contributor

andresmgot commented Oct 30, 2019 •

edited

Loading

Fixes issues in master: https://circleci.com/workflow-run/aec97cdb-f9e7-40dc-b192-e102ddc8456e

The expect() timeout is set using setDefaultTimeout.
~~- I have moved independent timeout sets from each test file to common configuration files.~~ Had to remove this. I don't know why it doesn't work in the CI environment.
I have increased the size of the browser window so the screenshots are more useful.
GKE doesn't use coredns so I removed the check for that component.

Andres Martinez Gotor added 4 commits

October 30, 2019 15:50


          Fix browser tests

d396e4f


          Launch tests in GKE

aa822ce


          Set timeout per test file

59f7b03


          Revert "Launch tests in GKE"

1bb0532

This reverts commit aa822ce.

Contributor Author

andresmgot commented Oct 30, 2019

merging this to unblock master

andresmgot merged commit a1a8eee into master

andresmgot deleted the fixBrowserTests branch

January 10, 2020 10:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet