Remove requirement for cluster-admin for tiller in openshift example. #1265
Conversation
There was a problem hiding this comment.
Thanks for the update!
To know your thoughts, what do you think about running our e2e tests against minishift (or similar)? We probably don't want to do so if it's not stable or if it's too slow but if we don't it, it's also likely that the code in the Makefile will become obsolete.
(Unrelated) I will fix the issue with the browser tests that is failing here.
Yes - I'd love to add that along with e2e tests against an oauth2 setup etc. I'm assuming we don't use kind for the normal e2e tests atm, but will take a look soon. |
Yes, we do. Let me know if you need more info about that. |
Fixes #676 .
This PR fixes one remaining issue I had with the development environment on OpenShift, removing the need to use
cluster-adminfor tiller. Together with the work from the past iteration, Kubeapps now installs without issue on OpenShift.I'm not keen to make a stronger statement about OpenShift support for a few reasons, so have updated the relevant part of the troubleshooting in the README to mention our tentative support and link to the RBAC policies as examples for the related issue.
As per TODOs in the doc, I don't think the RBAC requirements are specific to OpenShift, but rather we should be promoting these as the default (for helm2 / tiller - we don't seem to mention working with non-cluster-admin tiller anywhere that I can see. Checked our access-control doc but that is Kubeapps specific)