-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cluster-kind.mk with setup for k8s api server oidc configured with test CA #1270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume there's a way I can check locally that this doesn't impact e2e tests (it shouldn't, but I'd like to check tomorrow).
The e2e test are being executed in this PR so no problem.
Q: Is there a reason to store these certs in the repo at all? I could have them as make targets which just get generated if not present etc.?
I think I added them to the repo to save a bit of time.
--config=./devel/local-dev-apiserver-config.json \ | ||
--retain | ||
|
||
cluster-kind: ${CLUSTER_CONFIG} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you also need a target to load the kubeconfig-path
, no? export KUBECONFIG=$(kind get kubeconfig-path --name=kind)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makefiles don't let you change the external environment, each command is run in a subshell, which is a good thing... so what I want to do is separate the cluster creation helpers (like this one) from the kubeapps deployment configuration helper (which I'll add next). This is because deploying a configured oidc kubeapps example will be the same whether it's on a local kind or minishift or non-local env. So it'll be:
- Create your configured cluster (ie. with the oidc endpoint)
- Deploy the example kubeapps (which will configured for oidc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, I forgot that
I am not a enthusiast of Makefiles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, I forgot that
I am not a enthusiast of Makefiles
That's right - you mentioned and I wanted to hear more... next standup topic? :) (FWIW, I'm happy to use something else - I just don't see anything that fits the bill. Bash scripts need a lot of extra work to get the same benefits, imo, but I don't care that much).
This diff:
cluster-kind
target that starts a local k8s environment with OIDC support, configured to trust a test CA,I assume there's a way I can check locally that this doesn't impact e2e tests (it shouldn't, but I'd like to check tomorrow).
Q: Is there a reason to store these certs in the repo at all? I could have them as make targets which just get generated if not present etc.?
Ref: #1269