Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for nodeSelector on apprepository syncjob. Fixes #1255 #1273

Merged
merged 2 commits into from
Nov 5, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chart/kubeapps/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: kubeapps
version: 3.0.2
version: 3.0.3
appVersion: DEVEL
description: Kubeapps is a dashboard for your Kubernetes cluster that makes it easy to deploy and manage applications in your cluster using Helm
icon: https://raw.githubusercontent.com/kubeapps/kubeapps/master/docs/img/logo.png
Expand Down
6 changes: 5 additions & 1 deletion chart/kubeapps/templates/apprepositories.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ metadata:
spec:
type: helm
url: {{ .url }}
{{- if or $.Values.securityContext.enabled $.Values.apprepository.initialReposProxy.enabled}}
{{- if or $.Values.securityContext.enabled $.Values.apprepository.initialReposProxy.enabled .nodeSelector }}
syncJobPodTemplate:
spec:
{{- if $.Values.apprepository.initialReposProxy.enabled }}
Expand All @@ -30,6 +30,10 @@ spec:
securityContext:
runAsUser: {{ $.Values.securityContext.runAsUser }}
{{- end }}
{{- if .nodeSelector }}
nodeSelector:
{{ toYaml .nodeSelector | indent 8 }}
{{- end }}
{{- end }}
{{- if or .caCert .authorizationHeader }}
auth:
Expand Down
2 changes: 2 additions & 0 deletions chart/kubeapps/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ apprepository:
# Additional repositories
# - name: chartmuseum
# url: https://chartmuseum.default:8080
# nodeSelector:
# somelabel: somevalue
# # Specify an Authorization Header if you are using an authentication method.
# authorizationHeader: "Bearer xrxNC..."
# # If you're providing your own certificates, please use this to add the certificates as secrets.
Expand Down