Add diff view #1286
Merged
Add diff view #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
approved these changes
Nov 14, 2019
| // We compare the values from the old release and the new one | ||
| oldValues = this.props.deployedValues; | ||
| title = "New values to submit"; | ||
| emptyDiffText = "Values for the new release are identical"; |
There was a problem hiding this comment.
"The values for the new release are identical to the deployed version." ?
| // If there are already some deployed values (upgrade scenario) | ||
| // We compare the values from the old release and the new one | ||
| oldValues = this.props.deployedValues; | ||
| title = "New values to submit"; |
There was a problem hiding this comment.
"Difference from deployed version"? (matching how you've labelled the new deployment text below)
added 3 commits
November 14, 2019 11:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1235
Add a new tab in which we show the difference between the default values (or the values of the previous version) and the current values.
Example when deploying:
Example when upgrading:
If there are no changes:
I have changed the titles of the tabs to be more descriptive:
At the end, I am using the package
diff2htmlfor the diff view because I hit an issue with the stable version ofreact-diff-viewer: praneshr/react-diff-viewer#47