Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial LDAP support in local dev #1287

Merged
merged 2 commits into from
Nov 14, 2019

Conversation

absoludity
Copy link
Contributor

This PR adds an OpenLDAP deployment so that in addition to the login-by-email added previously, you can also login via LDAP.

Note: This is a WIP as something in this diff results in the api server being unable to verify signatures, so logins fail. I see the following in the apiserver logs:

4T05:38:30.142068621Z stderr F E1114 05:38:30.141968       1 authentication.go:65] Unable to authenticate the request due to an error: [invalid bearer token, oidc: verify token: failed to verify signature: failed to verify id token signature]

but haven't yet found the cause. Nonetheless, I think it's ready for review otherwise.

Fixes #1269

Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised dex works for both, with a connector and static password. Let me know if I can help with something

@absoludity
Copy link
Contributor Author

Note: This is a WIP as something in this diff results in the api server being unable to verify signatures, so logins fail. I see the following in the apiserver logs:

4T05:38:30.142068621Z stderr F E1114 05:38:30.141968       1 authentication.go:65] Unable to authenticate the request due to an error: [invalid bearer token, oidc: verify token: failed to verify signature: failed to verify id token signature]

but haven't yet found the cause. Nonetheless, I think it's ready for review otherwise.

I came to debug this this morning and it is working perfectly - I can log in either via LDAP or just the dex static user and get assigned the correct RBAC. I'll check later when re-creating whether it's related to timing of the keys (ie. they obviously hadn't expired, but perhaps clock-skew put it in the future).

I am surprised dex works for both, with a connector and static password. Let me know if I can help with something

Yeah, it's pretty neat.

@absoludity absoludity merged commit c84798e into vmware-tanzu:master Nov 14, 2019
@absoludity absoludity deleted the local-oauth-dev-3 branch November 14, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate and demo LDAP for Kubeapps
2 participants