Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsafe methods #1292

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Remove unsafe methods #1292

merged 1 commit into from
Nov 19, 2019

Conversation

andresmgot
Copy link
Contributor

Closes #1200

This PR removes UNSAFE_* methods. It also adds tests for the cases the related method were not covered.

absoludity
absoludity approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - glad there was such a 1-1 mapping with componentDidUpdate.

@andresmgot andresmgot merged commit aaa54a7 into vmware-tanzu:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absoludity absoludity absoludity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update React version and migrate deprecated hooks
2 participants
@andresmgot @absoludity