Fix downgrade when the schema is missing #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
approved these changes
Nov 21, 2019
| @@ -24,8 +24,8 @@ const chartsSelectedReducer = ( | |||
| error: undefined, | |||
| readmeError: undefined, | |||
| version: action.payload.chartVersion, | |||
| values: action.payload.values ? action.payload.values : state.values, | |||
There was a problem hiding this comment.
Is this the same as:
values: action.payload.values || state.values,
? But fine either way.
There was a problem hiding this comment.
it was the same, I changed it to just take into account the payload value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
If found another issue, while downgrading from a version that contains a schema to one that doesn't, the form didn't got removed. This is because in the reducer, we were checking that the schema exists to be set in the state (maintaining the previous state otherwise).