Delete failed installations #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
approved these changes
Dec 3, 2019
pkg/proxy/proxy.go
Outdated
| return nil, fmt.Errorf("Unable to create the release: %v", err) | ||
| errDelete := p.deleteRelease(name, namespace, true) | ||
| if errDelete != nil { | ||
| return nil, fmt.Errorf("Unable to create the release: %v and unable to uninstall it: %v", err, errDelete) |
There was a problem hiding this comment.
I wouldn't need to uninstall a release which was not created. I think helm's messaging here is a little clearer, in that the release failed. Something like:
"Release %q failed: %v. Unable to purge failed release: %v"
Though it'd be nicer to wrap the error (like the helm code for atomic does).
pkg/proxy/proxy.go
Outdated
| if errDelete != nil { | ||
| return nil, fmt.Errorf("Unable to create the release: %v and unable to uninstall it: %v", err, errDelete) | ||
| } | ||
| return nil, fmt.Errorf("Unable to create the release and has been uninstalled: %v", err) |
There was a problem hiding this comment.
Similarly here: "Release %q failed and has been uninstalled: %v"
| if err == nil { | ||
| t.Error("Release should fail, an existing release in a different namespace already exists") | ||
| } | ||
| if !strings.Contains(err.Error(), "already exists") { |
There was a problem hiding this comment.
Did you try adding a test for the actual deletion and it was not worth it for now? (given that tiller-proxy is dying).
There was a problem hiding this comment.
yes, there is no easy way for the current fake helm implementation to fail doing an installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
When creating a release, if it fails for some reason (like band inputs) clean up the release afterwards so the same name can be reused.
BTW, there is no an "atomic" flag that we can use in the CreateRelease action for helm, this is the code:
https://github.com/helm/helm/blob/456eb7f4118a635427bd43daa3d7aabf29304f13/pkg/action/install.go#L313
Possible drawbacks
If the release failed to be installed but it's not stored as a failed release (for example for an invalid name) we will be returning also an error for the missing release when trying to delete it, which might be confusing.
Applicable issues
cc/ @SimonAlling since these changes affect to tiller-proxy