Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break a word in the console if there is no other wrap option. #1338

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

absoludity
Copy link
Contributor

Description of the change
Before:
Screenshot from 2019-11-27 17-32-10

After:
word-break

Benefits
All text can be read without overflowing.

Possible drawbacks
Each line in the terminal text is no longer a single line necessarily?

Applicable issues

Additional information
We could instead use overflow: hidden but it's then difficult to actually see (or copy-n-paste) the text.

@absoludity absoludity requested a review from andresmgot December 3, 2019 06:45
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it's okay to show multiple lines since copy-pasting should work (pasting in a single line)

@absoludity absoludity merged commit f59f381 into vmware-tanzu:master Dec 3, 2019
@absoludity absoludity deleted the 1326-console-wrap branch December 3, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console text in AppView overflow
2 participants