Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve apprepository-controller build time #1355

Merged

Conversation

SimonAlling
Copy link
Contributor

See #1342.

I haven't worked with apprepository-controller, but this PR is helpful for make all at least.

Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making the build times faster.

Out of interest, when are you using make all? I generally just build the image for the service that I'm working on, but interested to know what your workflow is.

@absoludity absoludity merged commit c15cf9b into vmware-tanzu:master Dec 8, 2019
@SimonAlling
Copy link
Contributor Author

Out of interest, when are you using make all? I generally just build the image for the service that I'm working on, but interested to know what your workflow is.

"Workflow" might be a bit of a stretch, but I tend to make all sometimes when I want to be sure that everything is rebuilt. I usually do make all && make test before pushing at least.

@SimonAlling SimonAlling deleted the buildkit-apprepository-controller branch December 9, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants